-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix module visibility check #6685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjcnn
added
the
breaking
May cause existing user code to break. Requires a minor or major release.
label
Nov 1, 2024
CodSpeed Performance ReportMerging #6685 will not alter performanceComparing Summary
|
tritao
reviewed
Nov 1, 2024
tritao
previously approved these changes
Nov 1, 2024
tritao
approved these changes
Nov 1, 2024
tritao
reviewed
Nov 4, 2024
tritao
previously approved these changes
Nov 4, 2024
tritao
approved these changes
Nov 6, 2024
xunilrj
approved these changes
Nov 7, 2024
IGI-111
removed
the
breaking
May cause existing user code to break. Requires a minor or major release.
label
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6673.
The module visibility check has been broken for some time.
In some cases, like the one described in #6673, this has resulted in modules being mistakenly regarded as inaccessible, even though they ought to be accessible.
In other cases, private modules were mistakenly regarded as accessible. For examples see the updated tests in the PR.
The check has now been fixed, and all tests have been updated accordingly.
This bugfix can be regarded as a breaking change, because some modules that were deemed accessible before may now be deemed inaccessible and will require the addition of a
pub
keyword in front of the module declaration.Checklist
Breaking*
orNew Feature
labels where relevant.